-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table conversion fail when containing <h> tags #7
Comments
Are there nested tables? |
no prob, stars are always appreciated! |
Nope. (the above table example is the simplest that doesn't work) |
Yeah, that would make sense if it was intentional lol. Looks like a bug. I'll look into it, or a pr would be great. here is the table logic |
Oh, my JS knowledge is so basic, I have trouble looking through that :-)
|
A possible solution could be to actually convert |
(I can probably do this via the "preprocess" event though) |
Breakdance is unable to convert tables that contain text with
<h>
heading tags.Example:
(this converts to markdown that looks identical to the above input)
This behavior seems partially correct since
<h>
tags are not supported by tables.However, total failure of conversion to markdown cannot be justified simply because tables can contain any text like '#%&@#&!", so any unsupported or unrecognizable syntax should also be treated like text.
Therefore the expected output should be:
| <h3>Firstname</h3> | Lastname | Age |
The problem is further amplified by the fact that currently Breakdance leaves the whole
<table>
HTML syntax in the markdown output, thus making it no longer usable as markdown. At minimum any bad syntax could be removed or replaced with a warning like:[Unsupported HTML syntax - cannot be converted to markdown]
BTW, thanks Breakdance developers for your great contributions!
The text was updated successfully, but these errors were encountered: