Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic version numbers to pages #75

Closed
braydie opened this issue Mar 26, 2016 · 7 comments
Closed

Add semantic version numbers to pages #75

braydie opened this issue Mar 26, 2016 · 7 comments

Comments

@braydie
Copy link
Owner

braydie commented Mar 26, 2016

As per @xmalinov - #45 (comment) for keeping translated versions of the guide in sync

@braydie
Copy link
Owner Author

braydie commented Mar 28, 2016

Github-flavoured markdown doesn't support metadata, so it looks like I may need to add inline HTML into each file for the version number, either using <meta name="version" content="1.0.0" /> or something bespoke like <version number="1.0.0" />. Has anyone come across this sort of thing before or know of a better approach for including version numbers?

@ajsebastian
Copy link
Contributor

Hi! If you still need help doing this I would be more than willing to run through and insert this into the files.

@braydie
Copy link
Owner Author

braydie commented Apr 26, 2016

hey @ajsebastian, the issue that I've yet to resolve is how to add the version numbers so that they don't impact the readability of the pages on github or gitbook -- ideally, I want to be able to add the version numbers as metadata so that it doesn't render on the page

@ajsebastian
Copy link
Contributor

ajsebastian commented Apr 26, 2016

@braydie That makes a lot more sense. After looking into it for a while it seems that the best way to add comments to markdown files which won't appear in the github page (it will still show in the raw data) is to format your comments like this: [//]: # (This may be the most platform independent comment) .
Everything inside of the parenthesis will not show unless you look at the raw data. I tested on a markdown file in a test directory here: https://github.com/ajsebastian/ajsebastian.github.io/blob/master/Comment%20showcase.md and it seems to work in the Github environment. You can see the comments by going to the raw or blame tabs. Let me know if this helped!

Edit: Also works with Gitbook as well.

@ajsebastian
Copy link
Contributor

If you give me the version numbers and are satisfied with the comment method i could take this issue and update all of the files ASAP.

@ajsebastian
Copy link
Contributor

I submitted a pull request of a version of the project where every file has a version number comment at the top. Hope this was helpful.

@braydie
Copy link
Owner Author

braydie commented Apr 30, 2016

@ajsebastian that is awesome! I think there are probably a few differences between the English and Chinese version at present just down to natural drifting within each section, which we will just have to accept for the time being. Thank you so much for figuring this out! I'm tied up this weekend but will review and merge in the coming week!

@braydie braydie closed this as completed in 881896a May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants