Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurately provide cr_button disabled to leo-button #23835

Merged
merged 1 commit into from
May 29, 2024

Conversation

petemill
Copy link
Member

@petemill petemill commented May 26, 2024

Normally the fix should be to bind with $= to tell Polymer that isDisabled is a boolean attribute. However, the LeoButton actually seems to only work if some string value is provided. See brave/leo#690

Resolves brave/brave-browser#38542 by making the button actually disabled

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this May 26, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 26, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Normally the fix should be to bind with $= to tell Polymer that isDisabled is a boolean attribute. However, the LeoButton actually seems to only work if some string value is provided.
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@petemill petemill merged commit b7766ce into master May 29, 2024
19 checks passed
@petemill petemill deleted the cr_leo_button_disabled branch May 29, 2024 16:19
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 29, 2024
brave-builds added a commit that referenced this pull request May 29, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.68.64 Chromium: 126.0.6478.26 (Official Build) nightly (64-bit)
-- | --
Revision | d9689f56dafd3c9d8622461f6b4864053b0706aa
OS | Windows 11 Version 23H2 (Build 22631.3672)

Reproduced the original crash using the STR/Cases outlined via brave/brave-browser#38542 (comment) using 1.68.59 Chromium: 126.0.6478.17 as per the following:

reproducedCrash.mp4

Using the same STR/Cases mentioned above, ensured that Brave wasn't crashing when using 1.68.64 Chromium: 126.0.6478.26 as per the following:

FixedProfileCrash.mp4

kjozwiak pushed a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when creating a new profile
4 participants