Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#38505
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Resource test plans:
Ensure the following resources are loaded and that the log shows
Successfully loaded and parsed ... resource version
when the requirements are met. If the requirements are not met, the resources should be unloaded. Ensure that resource updates are applied. Malformed resources should fail to load and displayFailed to load and parse ... resource
in the logs. Unavailable resources should display... resource is unavailable
in the logs.Require catalog resource only if:
Require anti-targeting resource only if:
Require purchase intent resource only if:
Require text classification resource only if:
Require conversion resource only if:
Other test plans:
Ensure the following features are supported when the requirements are met. If the requirements are not met, the features should not be supported.
Trigger a verifiable conversion only if:
Fetch subdivision (geo.ads.brave.com) only if:
Allow subdivision targeting (frequency capping) for United States of America or Canada only if: