Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Chat: enable conversation api feature flag #23783

Merged
merged 3 commits into from
May 29, 2024

Conversation

petemill
Copy link
Member

Resolves brave/brave-browser#38476

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this May 22, 2024
@petemill petemill requested a review from evq May 22, 2024 04:30
@petemill petemill force-pushed the ai-chat-conversation-api-enable branch from c23f4d6 to 3849a76 Compare May 22, 2024 22:30
@@ -319,7 +318,6 @@ EngineConsumerLlamaRemote::EngineConsumerLlamaRemote(
const mojom::Model& model,
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
AIChatCredentialManager* credential_manager) {
DCHECK(!features::kConversationAPIEnabled.Get());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not a great place to DCHECK anyway

@petemill petemill force-pushed the ai-chat-conversation-api-enable branch from 821ce20 to 51b16b5 Compare May 29, 2024 19:40
@petemill petemill merged commit 7462e07 into master May 29, 2024
17 checks passed
@petemill petemill deleted the ai-chat-conversation-api-enable branch May 29, 2024 21:36
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 29, 2024
petemill added a commit that referenced this pull request Jun 4, 2024
AI Chat: enable conversation api feature flag
kjozwiak pushed a commit that referenced this pull request Jun 5, 2024
Merge pull request #23783 from brave/ai-chat-conversation-api-enable

AI Chat: enable conversation api feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Chat: enable conversation API as engine provider
4 participants