Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Notification ads are shown when playing media #23584

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 11, 2024

Resolves brave/brave-browser#38225

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tmancey tmancey self-assigned this May 11, 2024
@tmancey tmancey requested a review from a team as a code owner May 11, 2024 14:04
brave-builds added a commit that referenced this pull request May 11, 2024
brave-builds added a commit that referenced this pull request May 11, 2024
@tmancey tmancey merged commit 3a994dd into master May 13, 2024
18 checks passed
@tmancey tmancey deleted the issues/38225 branch May 13, 2024 13:52
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 13, 2024
@btlechowski
Copy link

Verified with

Brave 1.68.12 Chromium: 125.0.6422.41 (Official Build) nightly (64-bit)
Revision 52fd851
OS Linux

Verified test plan from brave/brave-browser#38225

Test case 1

Verified ads are not shown when media is playing

[7096:7096:0513/220524.087539:VERBOSE2:permission_rules.cc(263)] Media is playing
[7096:7096:0513/220524.088343:VERBOSE1:notification_ad_serving.cc(77)] Notification ad not served: Not allowed due to permission rules

Test case 2

Verified ads are not shown when media is playing even when window was restored

[7096:7096:0513/220651.256893:VERBOSE2:permission_rules.cc(263)] Media is playing
[7096:7096:0513/220651.257177:VERBOSE1:notification_ad_serving.cc(77)] Notification ad not served: Not allowed due to permission rules

kjozwiak pushed a commit that referenced this pull request May 14, 2024
kjozwiak pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants