Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: split up glfm_platform_ios.c #1

Open
alexhunsley opened this issue Feb 27, 2017 · 4 comments
Open

Feature request: split up glfm_platform_ios.c #1

alexhunsley opened this issue Feb 27, 2017 · 4 comments

Comments

@alexhunsley
Copy link

alexhunsley commented Feb 27, 2017

This file contains GLFMAppDelegate and GLFMViewController, amongst other things.
Having this all in one files makes it harder to navigate to one of these things (e.g. in AppCode "quick open" then typing GLFMAppDelegate doesn't work).

It also makes tracking source control changes to one of these classes more tricky (e.g. I can't easily just see changes to GLFMViewController).

@brackeen
Copy link
Owner

The file will get split up at some point (trying to be more like GLFW) but not anytime soon. It's not too complicated of a file at the moment (less than 900 lines). I'll leave the issue open, but it's not a high priority.

Which IDE are you using? Quick open works in Xcode. Does your IDE pick up the #pragma mark lines?

@alexhunsley
Copy link
Author

alexhunsley commented Mar 7, 2017

I'm mainly using AppCode, where the quick open shortcut doesn't pick up on a class inside a file with a non-matching name. AppCode does parse #pragma marks though.

@willbamford
Copy link

I'm also interested in getting this to work with React Native. So, use RN for the general UI but GLFM for OpenGL visualisations. In this case I wouldn't want GLFM to create and manage AppDelegate but would instead want to use GLFMViewController. It feels like splitting out the functionality into different files would be a step towards allowing this perhaps?

@brackeen
Copy link
Owner

@webseed - That's doable, I created issue #11 for that.
I believe this is currently possible in the Android version (starting a GLFM-based Activity from another Activity) but have not tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants