Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reflection option for boundary handling in 1D correlation #613

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add reflection option for boundary handling in 1D correlation #613

wants to merge 1 commit into from

Conversation

meshtag
Copy link
Member

@meshtag meshtag commented Jun 3, 2021 •
edited

References

Depends on #612
resolves #608

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@meshtag meshtag added ext/numeric boost/gil/extension/numeric/ google-summer-of-code All items related to GSoC activities labels Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021 •
edited

Codecov Report

Merging #613 (1a2a908) into develop (843ea37) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #613      +/-   ##
===========================================
+ Coverage    78.76%   78.82%   +0.05%     
===========================================
  Files          117      117              
  Lines         5030     5038       +8     
===========================================
+ Hits          3962     3971       +9     
+ Misses        1068     1067       -1

lpranam
lpranam requested changes Jun 5, 2021
View reviewed changes
Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

test/extension/numeric/test_fixture.hpp Outdated Show resolved Hide resolved
@mloskot
Copy link
Member

mloskot commented Jun 3, 2022

@meshtag Could you tell what is the status of this PR? Is this going to be picked up or drop it and close it?

@mloskot mloskot added status/need-feedback Asking for more details about the problem status/work-in-progress Do NOT merge yet until this label has been removed! labels Jun 3, 2022
@meshtag meshtag mentioned this pull request Jun 3, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simmplecoder simmplecoder simmplecoder approved these changes

@lpranam lpranam lpranam approved these changes

Assignees
No one assigned
Labels
ext/numeric boost/gil/extension/numeric/ google-summer-of-code All items related to GSoC activities status/need-feedback Asking for more details about the problem status/work-in-progress Do NOT merge yet until this label has been removed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Reflection" option for boundary handling in 1D correlation.
4 participants
@meshtag @mloskot @simmplecoder @lpranam