Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

K8s Package Methods Should Return a List When Returning Objects #129

Open
Marios85 opened this issue Sep 2, 2021 · 0 comments
Open

K8s Package Methods Should Return a List When Returning Objects #129

Marios85 opened this issue Sep 2, 2021 · 0 comments

Comments

@Marios85
Copy link
Contributor

Marios85 commented Sep 2, 2021

Currently the Bodywork k8s package 'Get' methods return dictionaries. Now we have started to return objects e.g. display_secrets these should instead be returned as a list of objects because this is best practice for the retrieval of objects in the data layer.

However, at this moment in time Secrets is the only object that is returned from the data layer with the rest of the objects being dictionaries returning a specific value, therefore it should not be done now to maintain consistency in the data layer. These at some point will become objects too as we expand the data that is returned for each of these items. When this occurs we should refactor all these methods to return a list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant