Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexForm field enable_scrollwheelzoom has no effect #166

Open
simonschaufi opened this issue Mar 23, 2024 · 0 comments
Open

FlexForm field enable_scrollwheelzoom has no effect #166

simonschaufi opened this issue Mar 23, 2024 · 0 comments

Comments

@simonschaufi
Copy link
Contributor

simonschaufi commented Mar 23, 2024

The FlexForm field enable_scrollwheelzoom has no effect.

The setting is actually activated via TypoScript:

plugin.tx_odsosm_pi1 {
    enable_scrollwheelzoom = 1
}

thus it is always activated and can NOT be deactivated because of the way how the overwrite is called:

ArrayUtility::mergeRecursiveWithOverrule($this->config, $flex, true, false);

The problem here is the last false which ignores 0 values and thus deactivated values cannot deactivate the values from TypoScript but the Flexform values should be the strongest.

Is this the expected behavior? If so, then the FlexForm setting could be removed as it is useless. It only has an effect if the TypoScript value would set to 0 by someone else and then activate the FlexForm setting again individually.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant