Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cater for Inactive groups #17

Open
bobbingwide opened this issue Sep 1, 2023 · 1 comment
Open

Cater for Inactive groups #17

bobbingwide opened this issue Sep 1, 2023 · 1 comment
Assignees
@bobbingwide
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Sep 1, 2023 •
edited
Loading

While attempting to develop PHPUnit tests for the ACF field block I deactivated the Layout group that contained some cloned fields. The fields for this inactive group were still being included in the list of field names, overriding the original field called text.

Requirements

Fields from any group that has been marked as Inactive shouldn't be included in the selection list for the ACF field block
@bobbingwide bobbingwide added the enhancement New feature or request label Sep 1, 2023
@bobbingwide bobbingwide self-assigned this Sep 1, 2023
@bobbingwide
Copy link
Owner Author

Solution

Check that the field group is active in acf_field_block_get_possible_field_names()

bobbingwide added a commit that referenced this issue Sep 5, 2023
@bobbingwide
Don't process fields from Inactive groups #17. Cater for duplicate fi…
7caaed5 
…eld names #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbingwide bobbingwide

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobbingwide