-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the server is not available, the frontend should inform the admin #1482
Comments
Hey , I found this issue interesting to solve if possible can you assign this issue to me |
@jasneetsingh6114 can you write how you are going to implement this? Also do you have any previous, similar contributions that I can check? |
Hi @gorkem-bwl, Here’s how I plan to implement this feature: Polling Mechanism: State Management: Notification System: User Experience Enhancements: |
Thanks @jasneetsingh6114 - please get an understanding of the codebase before starting. Also make sure you check .github/pull_request_template.md file to have an understanding of what is expected from a pr. |
Hey @gorkem-bwl |
For now you can assume it will return "ok" from /health and move ahead. @ajhollid will come up with an implementation you can use soon. |
Hey @jasneetsingh6114, Polling a health check endpoint is overkill for this issue, there is no need to add that kind of traffic overhead. We already have an Axios reponse interceptor:
All you need to do is modify it slightly to deal with Axios Docs for your reference. In general, polling should be used very sparingly and there should be a very good reason to do so. |
Ah ok Alex, thanks for the clarification. |
No problem, sorry I was late to the discussion, I hope you didn't go too far down the health check path @jasneetsingh6114 Give me a ping if you'd like to discuss the implementaiton 👍 |
When the server is not available, the frontend should inform the admin.
Main flow can be as follows:
FYI @ajhollid for the BE endpoint.
The text was updated successfully, but these errors were encountered: