Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infratructure monitors should be editable #1277

Open
gorkem-bwl opened this issue Dec 4, 2024 · 3 comments · May be fixed by #1308
Open

Infratructure monitors should be editable #1277

gorkem-bwl opened this issue Dec 4, 2024 · 3 comments · May be fixed by #1308
Assignees
Labels
Milestone

Comments

@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Dec 4, 2024

Currently an infra monitor cannot be edited. We need to apply the same methodology we use in "Monitors" section. We can add a "Configure" button in details section of an infra monitor so the end user can edit and save again.

Here is a sample screenshot showing where the Configure button is (this is for the monitors section and you can apply the same method to the Infrastructure section):

image
@gorkem-bwl gorkem-bwl added good first issue Good for newcomers frontend labels Dec 4, 2024
@gorkem-bwl gorkem-bwl added this to the 2.1 milestone Dec 4, 2024
@peterpardo
Copy link
Contributor

Hello! I can work on this.

@gorkem-bwl
Copy link
Contributor Author

Sure, go ahead. Please check how it is implemented in Monitors section. Have a look at that area and check the behaviour as well. Also, attach a video when you are done.

Thank you.

@gorkem-bwl gorkem-bwl modified the milestones: 2.1, 2.0.1 Dec 6, 2024
@gorkem-bwl
Copy link
Contributor Author

gorkem-bwl commented Dec 6, 2024

FYI @peterpardo this will go into 2.0.1 minor release.

@peterpardo peterpardo linked a pull request Dec 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants