Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] - Add visual cue to Profile Settings #1121

Open
marcelluscaio opened this issue Nov 7, 2024 · 6 comments
Open

[FE] - Add visual cue to Profile Settings #1121

marcelluscaio opened this issue Nov 7, 2024 · 6 comments
Assignees
Labels
design Design related frontend
Milestone

Comments

@marcelluscaio
Copy link
Contributor

In the profile settings, the tabs (Profile, Password, Teams) do not provide visual cues for the focus state, making harder for keyboard navigation. Also, the border is misaligned.

There should be a visual cue when navigating between these interactive elements. It would be best if they follow these guidelines:
https://www.w3.org/WAI/WCAG21/Understanding/focus-visible.html
https://www.w3.org/WAI/WCAG22/Understanding/focus-appearance.html

I don't see an alternative implementation.

@marcelluscaio marcelluscaio changed the title Add visual cue to Profile Settings [FE] - Add visual cue to Profile Settings Nov 7, 2024
@guninwasan
Copy link
Contributor

Hey @marcelluscaio, can I work on this issue?

@marcelluscaio
Copy link
Contributor Author

Thank you for your interest, @guninwasan ! Yes, you can work on that

@guninwasan
Copy link
Contributor

guninwasan commented Nov 20, 2024

@marcelluscaio just wanted to get some more clarity on the issue. I tried keyboard navigation on profile both locally and the demo site, and it seems like there are visual cues to show what the tab the user is on

Screen.Recording.2024-11-19.at.21.25.56.mov
Screenshot 2024-11-19 at 21 20 07

@marcelluscaio
Copy link
Contributor Author

Yeah, of course! So that would be in the page itself, not on the navbar links.
Up here (and when you are the admin, there are two other tabs
Screenshot 2024-11-20 054004

@gorkem-bwl
Copy link
Contributor

@guninwasan just wanted to check back the progress here. Thanks!

@guninwasan
Copy link
Contributor

Hey @gorkem-bwl and @marcelluscaio the PR is up for review. Let me know if I need to make any changes to it. Thanks!

@gorkem-bwl gorkem-bwl modified the milestones: 2.1, 2.0.1 Dec 6, 2024
@gorkem-bwl gorkem-bwl added design Design related frontend labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related frontend
Projects
None yet
Development

No branches or pull requests

3 participants