Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required changes for handle.invalid spec change #254

Open
1 of 3 tasks
bnewbold opened this issue Jul 27, 2023 · 0 comments
Open
1 of 3 tasks

required changes for handle.invalid spec change #254

bnewbold opened this issue Jul 27, 2023 · 0 comments

Comments

@bnewbold
Copy link
Collaborator

bnewbold commented Jul 27, 2023

We've got work in progress in the typescript implementation to transmit handle.invalid for known repos when the handle fails to cross-verify. Some places indigo might need to do something special about this, with a focus on stuff in active development (not, eg the golang PDS impl):

  • search (palomar) should not index the value handle.invalid
  • XRPC server endpoints should disallow handle.invalid as a query parameter for params with string format handle. this could come for free if we just check at validation or db insert time, instead of every API query param?
  • BGS should return this value if handle verification fails. not sure if this is high priority

(possibly more, these were just the first I could think of)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant