Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSID syntax: formalize fragment and glob variations #352

Open
blowdart opened this issue Oct 5, 2024 · 1 comment
Open

NSID syntax: formalize fragment and glob variations #352

blowdart opened this issue Oct 5, 2024 · 1 comment
Labels

Comments

@blowdart
Copy link

blowdart commented Oct 5, 2024

The nsid spec mentions that a variation can contain an appended fragment and * as a glob character.

Neither appear in any of the valid test cases so it's unclear if we need to support them right now or not.

@blowdart blowdart added the bug Something isn't working label Oct 5, 2024
@bnewbold
Copy link
Contributor

bnewbold commented Oct 7, 2024

In both cases, I don't think we've fully formalized the grammar/restrictions yet. Eg, for fragments, what exact characters can show up in the fragment? For globs, do we support arbitrary string globs (app.bsk*), or only at a period position (app.bsky.*), can they be positional (app.*.feed.post), and are they recursive or does ** specify recursive.

The fragment syntax is used the in the wild for Lexicon references, so we should probably get that nailed down.

This repo isn't a bad place to file this issue, but we have just moved the interop test files over to https://github.com/bluesky-social/atproto-interop-tests, and the specs themselves are versioned in https://github.com/bluesky-social/atproto-website.

I'm going to move this issue over to the specs repo.

@bnewbold bnewbold transferred this issue from bluesky-social/atproto Oct 7, 2024
@bnewbold bnewbold changed the title Fragment interop test files do not include fragments or glob cases NSID syntax: formalize fragment and glob variations Oct 7, 2024
@bnewbold bnewbold added specs and removed bug Something isn't working labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants