-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack overflow with circular references. #26
Labels
Comments
I am having the same issue - was looking for a OpenAPI 3 validator, found cherrybomb (which looks amazing) - but sadly it fails when the api-docs contains circular references, in my case, this is caused because we have schema's referencing each other because of two way relations stuff |
Ive added for now a specific panic for circular references. Will soon add this as a passive test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When trying to analyse a specific swagger.json file, cherrybomb exits with a stack overflow.
To Reproduce
Steps to reproduce the behavior:
cherrybomb oas -f ./mvr.json
mvr.json.zip
Expected behavior
I would expect cherrybomb to identify the circular reference and warn on it.
Desktop (please complete the following information):
Additional context
The json setup of the swagger file won't make much sense. I sanitised it, and reduced what was a ~9k line file into something as small as I was willing to go without spending too much time on it. It reliably reproduces the problem I was observing.
Discussed in discord.
The text was updated successfully, but these errors were encountered: