Code cleanup

[das7pad]

These lines / instance attributes remain unused in the code:

• the keyword arguments as attributes, however there are no defaults are set, access is dangerous.
  

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Lines 49 to 50 in fee8d34

  	for key, item in list(kwargs.items()):
  	setattr(self, key, item)

  Let's drop the dynamic attribute access.

• a possibly expanded url or user defined url to short
  

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Line 68 in fee8d34

  self.expanded = url

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Line 100 in 1ea040e

  self.expanded = yield from instance.expand(url)

  Why do we store it?

• a possibly shortened url or user defined url to expand
  

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Line 88 in fee8d34

  self.shorten = url

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Line 75 in 1ea040e

  self.shorten = yield from instance.short(url)

  See above.

• The actual name of the derived BaseShortener:
  

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Line 40 in fee8d34

  self.engine = engine.__name__

And one more thing:

What were your thoughts to allow an actual derived BaseShortener (let's call it Demo) as the engine argument for a Shortener? One could simply create an instance of Demo and use the api of it?

[blikenoother]

• yes following code should be removed, I added with a thought of if any new shortner implementation need to have some new attribute
  

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Lines 49 to 50 in fee8d34

  	for key, item in list(kwargs.items()):
  	setattr(self, key, item)

• storing expanded url because let say you shorten a url and letter on in your code you want expanded url so you don't need to do a network call
  

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Line 68 in fee8d34

  self.expanded = url

• same reason as above, you may need shorten url and saving a network call
  

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Line 88 in fee8d34

  self.shorten = url

• I don't understand what's the problem here?
  

  aiourlshortener/aiourlshortener/shorteners/__init__.py

  Line 40 in fee8d34

  self.engine = engine.__name__

• Even I don't get following, please elaborate what you are trying to convey here?
  What were your thoughts to allow an actual derived BaseShortener (let's call it Demo) as the engine argument for a Shortener? One could simply create an instance of Demo and use the api of it?

[das7pad]

aiourlshortener/aiourlshortener/shorteners/__init__.py

Line 88 in fee8d34

self.shorten = url

await asyncio.gather(shortener.short('https://github.com/'),
                     shortener.short('https://github.com/blikenoother/aiourlshortener/'),
                     return_exceptions=True)

shortener.shorten can now store a short-url for 'https://github.com/' or one for 'https://github.com/blikenoother/aiourlshortener/'. It may also be None in case both short calls failed.

The point is that shortener.shorten does not store a predictable content.

---

aiourlshortener/aiourlshortener/shorteners/__init__.py

Line 40 in fee8d34

self.engine = engine.__name__

It is a calculated value and the user knows the content of it as he used it for the init. This one can be refactored in a property decorated function.

---

What were your thoughts to allow an actual derived BaseShortener (let's call it Demo) as the engine argument for a Shortener? One could simply create an instance of Demo and use the api of it?

We could refactor Shortener into a function which returns a derived BaseShortener instance.
There is no need to copy the public api of BaseShortener.

[blikenoother]

• agreed when it will be used in gather there will be issue, we don't need to set self.expanded and self.shorten

---

• yes user will know since he is initializing it with engine name

---

We could refactor Shortener into a function which returns a derived BaseShortener instance.
There is no need to copy the public api of BaseShortener.

can you pls explain this with sample code?

[das7pad]

can you pls explain this with sample code?

https://github.com/das7pad/aiourlshortener/tree/refactor-shortener-class