-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postman Module In-Scope workspaces #1783
Labels
bug
Something isn't working
Comments
These were the workspaces that were deemed to be "in-scope" from my search
|
This works well for some domains, since a small amount of noise is tolerable. But for others, especially ones with common stubs like Is it possible to filter down the search to only ones that contain the full target domain? EDIT: relevant issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I'm not sure the in scope check for the postman module is robust enough
This if statement matches if the org name is contained in the name of the workspace. For example I have an org name
Sage
This check matches the workspace name
Sagenda's Public Workspace
which probably shouldn't be in my scope. But workspaces likeSage Intacct Workspace
,Sage 200 API
should (Im probably using a little human intuition here as I know these are sage products)I'm not sure if a regex matcher would be better to check if the org name is not in the middle of a word or conjoined with another. Its more difficult than github as orgs don't necessarily have their own postman profile (Or at least they don't regularly in my experience)
The text was updated successfully, but these errors were encountered: