You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in general
in most of the primitive methods you have a lot of casting going on with Rpc and its sub-classes which is not needed (but isn't usually detrimental to functionality)
in fromBootstrapNode(L3Address bootstrapNode) in the catch the non-node address should be assigned to me (this isn't your fault, just something that needs updating)
in call(L3Address destination, Rpc RPC) the return type can/should be ResultRpcResponse
in primitiveLookup(L3Address remoteNode, Address destination)
Rpcs do not yet have toStrings, so when requestObject is written to the iowrapper, it needs to be requestObject.toJSONSTring()
Also, in "result = (TableResult)((ResultRpcResponse) responseObject).getResult().getValue();" I don't think you want that .getValue() on the end, especially considering the line that comes right after.
in general
in most of the primitive methods you have a lot of casting going on with Rpc and its sub-classes which is not needed (but isn't usually detrimental to functionality)
in fromBootstrapNode(L3Address bootstrapNode) in the catch the non-node address should be assigned to me (this isn't your fault, just something that needs updating)
in call(L3Address destination, Rpc RPC) the return type can/should be ResultRpcResponse
in primitiveLookup(L3Address remoteNode, Address destination)
Rpcs do not yet have toStrings, so when requestObject is written to the iowrapper, it needs to be requestObject.toJSONSTring()
Also, in "result = (TableResult)((ResultRpcResponse) responseObject).getResult().getValue();" I don't think you want that .getValue() on the end, especially considering the line that comes right after.
lets make all unimplemented methods (some flavors of call) throw an exception to indicate they are unimplemented http://docs.oracle.com/javase/7/docs/api/java/lang/UnsupportedOperationException.html
The text was updated successfully, but these errors were encountered: