Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues for Anna #98

Open
nrktkt opened this issue Apr 8, 2015 · 1 comment
Open

Issues for Anna #98

nrktkt opened this issue Apr 8, 2015 · 1 comment
Assignees

Comments

@nrktkt
Copy link
Member

nrktkt commented Apr 8, 2015

in general
in most of the primitive methods you have a lot of casting going on with Rpc and its sub-classes which is not needed (but isn't usually detrimental to functionality)

in fromBootstrapNode(L3Address bootstrapNode) in the catch the non-node address should be assigned to me (this isn't your fault, just something that needs updating)

in call(L3Address destination, Rpc RPC) the return type can/should be ResultRpcResponse

in primitiveLookup(L3Address remoteNode, Address destination)
Rpcs do not yet have toStrings, so when requestObject is written to the iowrapper, it needs to be requestObject.toJSONSTring()
Also, in "result = (TableResult)((ResultRpcResponse) responseObject).getResult().getValue();" I don't think you want that .getValue() on the end, especially considering the line that comes right after.

lets make all unimplemented methods (some flavors of call) throw an exception to indicate they are unimplemented http://docs.oracle.com/javase/7/docs/api/java/lang/UnsupportedOperationException.html

@annak3
Copy link
Contributor

annak3 commented Apr 8, 2015

Thanks! I'll get on that asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants