-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Allow shader code to override version #2977
Comments
Shaderc does not check the source for shader versions, the shader version is set when you invoke shaderc Eg: The best way to have diverging shader versions would be to have diverging shaderc invocations in your makefile |
This I am aware of, thats the feature request. While its easy to say just diverge in the makefile its a bit of a pain to setup for just one or two shaders. Atleast the way I have it atm, on make the shaders are compiled from directory structure like: if xyz2 uses a diff version, exlcuding it and invoking shaderc again is a bit painful. especially when its only GLSL/OpenGL that needs updating |
I have my pipeline setup well so that I only need to invoke shaderc from a single source (like the example shader Makefiles). Works great, but for only a few shaders I require a higher shader version. Setting the standard GLSL
#version 430
or whatever doesnt work and produces errors when trying to compile.I don't see that shaderc checks for existing version definitions, could it? I'm not sure how to best address defining the versions across different compilation targets. Perhaps it'd require something like:
(but i find this ugly)
Thoughts/concerns? I am happy to try contribute this feature if a decision can be made on above
The text was updated successfully, but these errors were encountered: