Include 'rejected' status in api/reviews/all API Endpoint
#294
Assignees
Labels
Comments
Extheoisah
added a commit
that referenced
this issue
Jun 20, 2024
This commit adds 1. the functionality to compute the review status for all reviews when queried from the database. This computation is done on the API level and is not stored in the db. 2. a new "rejected" review status based on the criteria outlined [here](#294)
Extheoisah
moved this from 🆕 Todo
to 🏗 In Progress
in The Bitcoin Development Project Roadmap
Extheoisah
moved this from 🏗 In Progress
to 👀 In Review
in The Bitcoin Development Project Roadmap
kouloumos
moved this from 👀 In Review
to 🏗 In Progress
in The Bitcoin Development Project Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have the
api/reviews/allAPI endpoint that lets us fetch reviews based on their status: expired, pending, active, or merged. However, we are missing one important status: rejected reviews. These are reviews where the pull request (PR) was closed without merging.Identifying Rejected Reviews
A review can be classified as 'rejected' if it meets all of the following criteria (to be confirmed by @Extheoisah):
Proposed Change
We need to update the
api/reviews/allendpoint to include 'rejected' as a status option. This will allow us to track and manage these reviews more effectively, ensuring that all types of review outcomes are visible and accounted for in our system.The text was updated successfully, but these errors were encountered: