-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
landing page overall fixes #35
Conversation
IgboPharaoh
commented
Sep 18, 2024
- This PR introduces a couple of fixes for the landing page to satisfy issue Current Issues with the Landing Page #33
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good overall! I've verified that all the issues have been resolved, except for the favicon fidelity. The favicon issue might require further discussion since the logo contains too many words to be displayed clearly in any setup.
A few other notes on this PR:
- The navbar height is reduced and it's no longer sticky at the top. I actually prefer this change.
- The hero section now starts as a single line, which is great. However, the second sentence should remain unbroken. If it wraps to a new line, the entire sentence should shift to the second line. @IgboPharaoh can we fix this nit?
One suggestion for future PRs: It would be helpful if each fix for a sub-issue was committed separately. This makes it easier to review specific changes, as the related code adjustments would be clear
|
For the favicon, I think it's a discussion we need to have with the rest of the team especially Tobi. |
In my previous comment I said that I liked the removal of the "stickiness". But I'm okay either way. Is that specified on the designs?
Have you tried what I suggested here? |
Addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, seems we have got the update of transcript favicon left. do we wait for tobi's update or just merge that in a later PR?
5d1e798
to
1f16071
Compare
@IgboPharaoh |
0a3507d
to
bb86248
Compare
* landing page overall fixes * fix: make navbar sticky * make subtext a standalone
* landing page overall fixes (#35) * landing page overall fixes * fix: make navbar sticky * make subtext a standalone * Transcript content page (#23) * feat: base layout for explore * feat: transcripts content page components * fix: made scroll behaviour smooth * feat: on scroll functionaity * feat: mobile page and moving components from app to components * fix: adding link on mobile * refactor: created topics-data.json and chnaged grouping functions to match * nit: modified contentlayer config * feat: speakers grouping on explore * feat: categories explore page * nit: fix type error on exploreTranscript * fix: breadcrumbs dynamic * nit: removed .json from being tracked on git * nit" changed package.json version * nit: package updated to 1.3.0 * nit: changes linkName on categories * fix: categories speakers in tags * fix: removed .vscode and added to .gitignore * nit: changed font sizes in layout and content grouping * fix: moved all /transcripts to /categories * design: added psuedo for select container * fix: nit--fixes from PR #43 (#44) --------- Co-authored-by: Solomon eze <[email protected]> Co-authored-by: 0tuedon <[email protected]>