Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: CPPFLAGS usage in OSS-Fuzz #29385

Closed
hebasto opened this issue Feb 5, 2024 · 3 comments
Closed

build: CPPFLAGS usage in OSS-Fuzz #29385

hebasto opened this issue Feb 5, 2024 · 3 comments

Comments

@hebasto
Copy link
Member

hebasto commented Feb 5, 2024

In OSS-Fuzz, dependencies are built with DEBUG=1, which implies usage of the additional preprocessor definitions:

$ make -C depends print-host_debug_CPPFLAGS HOST=x86_64-pc-linux-gnu DEBUG=1
...
host_debug_CPPFLAGS=-D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_ENABLE_DEBUG_MODE=1

However, explicit setting CPPFLAGS breaks this assumption:

$ make -C depends print-host_debug_CPPFLAGS HOST=x86_64-pc-linux-gnu DEBUG=1 CPPFLAGS="-DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE"
...
host_debug_CPPFLAGS=-DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE

Is this expected/desired behaviour?

@maflcko
Copy link
Member

maflcko commented Feb 5, 2024

Same in ci/test/00_setup_env_native_fuzz_with_msan.sh?

@fanquake
Copy link
Member

Should be closed after google/oss-fuzz#11725.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants