-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-rpc-images action might not be building PR branches #322
Comments
I think the issue is that https://github.com/bitcoin-dev-project/warnet/blob/93630d1956fea59960dfa95a247529a1f1a6ccbe/.github/workflows/build-rpc-images.yml#L14C15-L14C44 does auto-checkout of the repo using the git context, but perhaps this is not actually checking out the branch, but only cloning? |
It seems to be here: https://github.com/bitcoin-dev-project/warnet/actions/runs/8454179209/job/23158601186#step:5:154 I found a related issue too. Not sure why it's not working, I can check out that commit just fine locally... I guess we can try the non-"git context" way |
The PR 315 image:
https://hub.docker.com/layers/bitcoindevproject/warnet-rpc/pr-315/images/sha256-eb24aaa9dd31d30ddef7d96d3375946f2a1e74fa230c10546a70572e3bcade45?context=explore
did not have the correct RPC code in the container when deployed on K8s, it looked like it was on main branch
The text was updated successfully, but these errors were encountered: