Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide stack visualization for fully-unexecuted evaluations #47

Open
bitjson opened this issue Jul 28, 2020 · 2 comments
Open

Hide stack visualization for fully-unexecuted evaluations #47

bitjson opened this issue Jul 28, 2020 · 2 comments

Comments

@bitjson
Copy link
Member

bitjson commented Jul 28, 2020

While all evaluations occur during compilation, we can safely hide the internal stack visualization for evaluations which result in bytecode which is never executed. E.g. the stack visualization (current_block_time delay_seconds ...) for the evaluation in this locking script should be hidden since it's not relevant for the active unlocking script:
Screen Shot 2020-07-28 at 8 59 14 AM

@bitjson
Copy link
Member Author

bitjson commented Sep 26, 2023

Related: we should continue to show the stack visualization for internal evaluations even if their parent script is failing to compile. (Often, the internal evaluation being incorrect is the root cause of the outer compilation failure, but it's tedious to debug without a stack visualization for the internal evaluation.)

@bitjson
Copy link
Member Author

bitjson commented Jun 25, 2024

Also related: there was a regression between 1846ad1 (deployed) and cd8c0a0 (deployed) in which spacers for lines ending inside internal evaluation are no longer nested within the spacers of the parent evaluation.

E.g. before:

Screenshot 2024-06-25 at 4 47 50 PM

After:

Screenshot 2024-06-25 at 4 45 18 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant