"Highly recommended" exclusion patterns in "Manage profiles" GUI dialog should show only missing patterns

[aryoda]

Current status

rsync and therefor BiT do allow to specify "exclude file patterns" for files that shall not be rsynced:

Currently the GUI always shows all recommended (= default) exclusion file patterns:

Feature request

It would be more helpful to show only those default exclusions patterns as "highly recommended" that are not already contained in the actual exclusion list.

Relevant code

backintime/qt/settingsdialog.py

Lines 556 to 561 in d583cf8

	label = QLabel(_('Highly recommended') + ':', self)
	qttools.setFontBold(label)
	layout.addWidget(label)
	label = QLabel(', '.join(sorted(self.config.DEFAULT_EXCLUDE)), self)
	label.setWordWrap(True)
	layout.addWidget(label)

backintime/common/config.py

Lines 98 to 119 in d583cf8

	# Used when new snapshot profile is created.
	DEFAULT_EXCLUDE = [
	'.gvfs',
	'.cache/*',
	'.thumbnails*',
	'.local/share/[Tt]rash*',
	'*.backup*',
	'*~',
	'.dropbox*',
	'/proc/*',
	'/sys/*',
	'/dev/*',
	'/run/*',
	'/etc/mtab',
	'/var/cache/apt/archives/*.deb',
	'lost+found/*',
	'/tmp/*',
	'/var/tmp/*',
	'/var/backups/*',
	'.Private',
	'/swapfile',
	]

Related to

• Add describing comments to default exclude list entries (was: Add in-filesystem snapshots to default exclusion list) #1583
• Add tooltip/explanation for color-highlighted "Exclude" entries in "SSH encrypted" mode #1618
• Best practices to exclude cache folders to speed up backup #1594
• Exclude BiT files from the backups by default? #1382
• Folder contents was not excluded when exclude pattern was */.AppName/files/* #1215
• Select directories/files to include/exclude in tree view with checkboxes #972

[Prakul95]

#1629 pull request for dev branch.