Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃搸 Implement media-feature-name-no-unknown #2626

Closed
Tracked by #2511
togami2864 opened this issue Apr 28, 2024 · 3 comments 路 Fixed by #2751
Closed
Tracked by #2511

馃搸 Implement media-feature-name-no-unknown #2626

togami2864 opened this issue Apr 28, 2024 · 3 comments 路 Fixed by #2751
Assignees
@Kazuhiro-Mimaki
Labels
A-Analyzer Area: analyzer A-Linter Area: linter good first issue Good for newcomers L-CSS Language: CSS

Comments

@togami2864
Copy link
Contributor

togami2864 commented Apr 28, 2024 •
edited

Description

Implement media-feature-name-no-unknown

Important

  • Please skip implementing options for now since we will evaluate users actually want them later.
  • Please ignore handling extended CSS language cases such as sass and less.
  • Please skip custom function since we haven't syntax model yet.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.
@togami2864 togami2864 mentioned this issue Apr 28, 2024
Open
34 tasks
@togami2864 togami2864 added good first issue Good for newcomers A-Linter Area: linter L-CSS Language: CSS A-Analyzer Area: analyzer labels Apr 28, 2024
@Kazuhiro-Mimaki
Copy link
Contributor

I'm interested in tackling this issue 馃

@Kazuhiro-Mimaki
Copy link
Contributor

Kazuhiro-Mimaki commented May 1, 2024 •
edited

I'd like to reference media features like https://github.com/stylelint/stylelint/blob/main/lib/reference/mediaFeatures.mjs#L56
I searched project directories but I couldn't find.
Is there a reference? Or, do I have to make?

@togami2864
Copy link
Contributor Author

You should define them here.
https://github.com/biomejs/biome/blob/main/crates/biome_css_analyze/src/keywords.rs

@Kazuhiro-Mimaki Kazuhiro-Mimaki mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kazuhiro-Mimaki Kazuhiro-Mimaki

Labels
A-Analyzer Area: analyzer A-Linter Area: linter good first issue Good for newcomers L-CSS Language: CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(biome_css_analyzer): implement noUnknownMediaFeatureName Kazuhiro-Mimaki/biome
2 participants
@togami2864 @Kazuhiro-Mimaki