Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captus: specify megahit version number for linux builds #52888

Open
mptrsen opened this issue Dec 18, 2024 · 4 comments
Open

captus: specify megahit version number for linux builds #52888

mptrsen opened this issue Dec 18, 2024 · 4 comments

Comments

@mptrsen
Copy link
Contributor

mptrsen commented Dec 18, 2024

Without version number, this can pull in an old version of megahit that is missing critical command line options (such as --tmp-dir). As a result, the Captus assembly stage fails, silently.

Remove the non-versioned megahit entry in meta.yaml and use v1.2.9 for both builds:

- megahit # [linux]
- megahit =1.2.9=hfbae3c0_0 # [osx]

@edgardomortiz thank you! 🙏

@edgardomortiz
Copy link
Contributor

Thanks @mptrsen, maybe you have a suggestion for this specific issue. There is a newer build for OSX than hfbae3c0_0, however the new one has compilation problems and doesn't run properly, that is why I was trying to require this specific older build. Unfortunately the build hfbae3c0_0 is always ignored and one has to install it manually (therefore I added these instructions in our README).

If a specific build can't be invoked I would leave the recipe as:

  • megahit =1.2.9

Otherwise I would try:

  • megahit =1.2.9 # [linux]
  • megahit =1.2.9=hfbae3c0_0 # [osx]

Which would be your suggestion?

Thanks,

Edgardo

@mptrsen
Copy link
Contributor Author

mptrsen commented Dec 18, 2024

@edgardomortiz thanks for your swift response!

If the OSX build hfbae3c0_0 is ignored and needs to be installed manually anyway then I would simplify the recipe to

- megahit =1.2.9

Manual installation is suboptimal, I hope the OSX users see the notice in the README.

Thank you!

@edgardomortiz
Copy link
Contributor

Yeah, I thought so, I was hoping there was a reliable method to point to a specific build.

Thanks @mptrsen

@edgardomortiz
Copy link
Contributor

@mptrsen I opted for the following:

    - megahit >=1.2.9 # [linux]
    - megahit =1.2.9=hfbae3c0_0 # [osx]

The checks passed, just waiting for the merge.

Thanks,

Edgardo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants