Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode/Decode implementations are stored in target directory #531

Closed
mahkoh opened this issue Mar 31, 2022 · 3 comments · Fixed by #600
Closed

Encode/Decode implementations are stored in target directory #531

mahkoh opened this issue Mar 31, 2022 · 3 comments · Fixed by #600
Labels
bincode-2 enhancement stale

Comments

@mahkoh
Copy link

mahkoh commented Mar 31, 2022

I've been using bincode 2.0.0-rc.1 and I've noticed files using the pattern AccelProfile_Decode.rs being generated directly in the target directory. Would it be possible to move these files to a bincode-specific directory?
xobs added a commit to xobs/bincode that referenced this issue Apr 1, 2022
@xobs
atomic: remove AtomicI64/AtomicU64 on riscv32
a309baf 
The riscv32 platform does not have AtomicI64 or AtomicU64, so remove
those implementations on that platform.

This fixes bincode-org#531.

Signed-off-by: Sean Cross <[email protected]>
@VictorKoenders
Copy link
Contributor

What directory are you thinking of? Maybe generate target/bincode_gen and put the files in there?

@stale
Copy link

stale bot commented May 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 31, 2022
@stale stale bot closed this as completed Jun 7, 2022
@VictorKoenders VictorKoenders mentioned this issue Oct 13, 2022
Closed
@trevyn trevyn mentioned this issue Oct 19, 2022
Merged
@trevyn trevyn mentioned this issue Nov 3, 2022
Merged
@dtolnay
Copy link
Contributor

dtolnay commented Dec 3, 2022

This was reopened as #594 and resolved by #600.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bincode-2 enhancement stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move generated files to target/generated/bincode trevyn/bincode
3 participants
@mahkoh @dtolnay @VictorKoenders