Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid app id is missing rules #201

Open
A6GibKm opened this issue Jan 12, 2023 · 3 comments
Open

Check for valid app id is missing rules #201

A6GibKm opened this issue Jan 12, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@A6GibKm
Copy link

A6GibKm commented Jan 12, 2023

https://github.com/bilelmoussaoui/flatpak-vscode/blob/master/src/manifestUtils.ts#L91-L132 is

  • Not checking for numeric (0..9) characters, its only checking for a-z, A-Z, -, _.
  • Not checking if - is only in the last segment.
@SeaDve
Copy link
Collaborator

SeaDve commented Jan 16, 2023

Not checking for numeric (0..9) characters, its only checking for a-z, A-Z, -, _.

I believe it also checks 0..9 characters through isNumber.

@A6GibKm
Copy link
Author

A6GibKm commented Jan 16, 2023

Oh you are right, I didn't saw it.

@A6GibKm
Copy link
Author

A6GibKm commented Jan 16, 2023

It only leaves us with the - issue, but it might not be part of the spec but an unfortunate consequence of dbus rules.

@bilelmoussaoui bilelmoussaoui added the enhancement New feature or request label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants