Skip to content
This repository has been archived by the owner on Dec 26, 2018. It is now read-only.

Removing media profile causes torrent to have different infohash #3

Open
CirnoT opened this issue Aug 16, 2017 · 2 comments
Open

Removing media profile causes torrent to have different infohash #3

CirnoT opened this issue Aug 16, 2017 · 2 comments

Comments

@CirnoT
Copy link

CirnoT commented Aug 16, 2017

Media profiles that are being removed are inside info dict - removing them will cause torrent to have different infohash

unset($data['info']['profiles']);

@abixalmon
Copy link
Member

making it private already causes torrent to have different info_hash.

@CirnoT
Copy link
Author

CirnoT commented Nov 22, 2017

Correct, however trackers using it must be aware of it and make sure user redownloads torrent after upload if media profiles are detected. It may also be an issue if torrent was previously uploaded without removing media profile, set to private after upload and now is being downloaded by some other user (possibly years after original one was uploaded) - since the only way to set new announce_url is to execute make_private it will also remove media profile resulting in downloaded torrent file having different infohash than stored in tracker database.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants