Genbank file is not optional

[mthang]

It is misleading to see the genbank is labeled as optional (line 100) in this wrapper. Line 21 tells otherwise if I am not mistaken.

galaxytools/tools/mitohifi/mitohifi.xml

Line 21 in af8605d

ln -s '${operation_mode.reference_genbank}' related_mito.gb

[bgruening]

True, but which one is correct?

[mthang]

My colleague and I tested the MitoHiFI with genbank file provided , and it works. The tool fails without the genbank file. It looks like the genbank file is a requirement for MitoHiFI according to this git repo https://github.com/marcelauliano/MitoHiFi

[bgruening]

Ok, cool, do you remove the optional="true" or should I?

[mthang]

Yes. remove the optional="true" at your end. I also spotted the multiple="true" in the wrapper for the genbank file input and I dont know if the MitoHiFI could take a list of genbank file as an input.