Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: derive trait implementations on cubic spline structs #13190

Closed
mweatherley opened this issue May 2, 2024 · 0 comments · Fixed by #13293
Closed

Cleanup: derive trait implementations on cubic spline structs #13190

mweatherley opened this issue May 2, 2024 · 0 comments · Fixed by #13293
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@mweatherley
Copy link
Contributor

What problem does this solve or what need does it fill?

Right now, the cubic curve builder structs (and output to some degree) do not implement Clone and Debug where they all probably ought to. I have not looked super-closely, but I also recall that some data in bevy_math/src/cubic_splines.rs should actually be Copy but don't presently derive it, which can be annoying ergonomically (and is more of an issue).

What solution would you like?

#[derive()] away!
@mweatherley mweatherley added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels May 2, 2024
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A simple quality-of-life change that makes Bevy easier to use A-Math Fundamental domain-agnostic mathematical operations S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon and removed C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels May 2, 2024
@aristaeus aristaeus mentioned this issue May 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 12, 2024
@aristaeus
Add copy, clone, and debug derives to cubic spline structs (#13293)
6f641e9 
# Objective

Fixes #13190

---------

Co-authored-by: Ben Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add copy, clone, and debug derives to cubic spline structs aristaeus/bevy
2 participants
@mweatherley @alice-i-cecile