Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested overdrive animations #34

Open
aholachek opened this issue Jul 7, 2017 · 1 comment
Open

Nested overdrive animations #34

aholachek opened this issue Jul 7, 2017 · 1 comment

Comments

@aholachek
Copy link

Hello, I was experimenting with this (very cool) library trying to do some slightly more complex animations and ran into some issues with duplicate nested elements. Here's a demo of the problem I encountered.

I was able to achieve an effect closer to what I wanted (the "animation with hacked overdrive" tab in the example) by editing react-overdrive to expose a new "animationStart" prop function that hands the ref of the source and target cloned elements to the outer react element, which can use DOM methods on the content of the cloned elements while the outer overdrive animation is in progress. A messy, non-pull-request-ready version of that code is here.

Is this a feature you might think about adding to the library? If so, I will try to make a pull request.

@berzniz
Copy link
Owner

berzniz commented Jul 14, 2017

Thanks for all the information here. I'm going to take a deeper look into it and see if this can be added

BTW, the demo looks awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants