Fix help page ghosting #132
Conversation
The last reference to this was removed in dfbd1f3
This was causing ghosting issues on macOS when using terminal and iTerm2. I'm not entirely sure why this was causing problems in the first place but this heavy handed solution seems to work.
|
Thanks for putting this PR together! I tested it on the stock Terminal application where I am able to reproduce the issue, and it properly clears out the info from the help screen, but the top and bottom banner glitch out when viewing the actual help screen. Does that happen on your end as well? The intended behavior is that the top and bottom banner don't disappear when we view the help screen. |
|
That is interesting. It seems I "solved" one issue by creating another one... I'll take some more time to look into this. On this old iMac of mine, I initially see the footer but not the header. When I scroll down the header appears. When I scroll back to the top the footer completely disappears. I should test it on a newer machine to see what it looks like. I also wonder if these could potentially be bugs in bubble tea but that's just wild speculation on my part. Either way, I'll mark this as draft for now. |
|
Yeah, I think this is probably a bug in bubble tea. I added some logging to the |
|
I'm not sure how to fix this so I'll just close it. Very weird... |
|
Very strange.. Thank you for the PR and looking into it anyways 🙏 , hope it can be resolved one day. |
This fixes #131. I'm not entirely sure why this ghosting effect doesn't appear consistently on different terminal emulators but clearing the screen explicitly after exiting the help page seems to do this trick.
I also removed a function I found that's no longer being referenced while I was in the code.