Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Terminal does not treat U+2063 as an invisible character #123

Open
chromatic-aberration opened this issue Jul 29, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@chromatic-aberration
Copy link

chromatic-aberration commented Jul 29, 2024

U+2063 ( Invisible Comma = "⁣" ) used in comments is not being treated as an invisible character in Windows Terminal. This seems to be unrelated to the picked font either (or the -n flag).
This results in following behaviour:
image

I am aware this is an issue on the side of Windows Terminal, but it seems like they have had similar unicode characters not being invisible as intended issues already reported a while ago with no sign of progress on fix on their side as of yet, so maybe here some alternate character or a flag could be implemented?

This behaviour was observed on circumflex v3.7 and windows terminal v1.20.11781.0

@bensadeh
Copy link
Owner

bensadeh commented Aug 4, 2024

Hi @chromatic-aberration !

Thanks for using clx and thanks for letting me know about this.

It does indeed seem like a bug in the windows terminal, but that doesn't mean we can't find a good workaround.

Just some context: we use this symbol to collapse/expand the comment section from within less. Using h or k, we can filter out these special characters in real time, giving the impression that we expand or collapse the comments.

I think for this case, we can just find a suitable replacement unicode character that is invisible in both windows and unix/mac.

There need to be changes in two places:

If you're able to find a good replacement unicode character, I'd be happy to receive a PR so that I can again test the changes on the mac side of things.

@bensadeh bensadeh added bug Something isn't working help wanted Extra attention is needed labels Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants