We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced classes still do call parent default constructor e.g.:
CaptureStackTrace call is redundant, it comes from StackTrace() constructor.
CaptureStackTrace
StackTrace()
In this case, we could explicitly call StackTrace(StackFrame frame) with some dummy value, to avoid an expensive call:
StackTrace(StackFrame frame)
public EnhancedStackTrace(Exception e) : base((StackFrame) null) { if (e == null) { throw new ArgumentNullException(nameof(e)); } _frames = GetFrames(e); } public EnhancedStackTrace(StackTrace stackTrace) : base((StackFrame) null) { if (stackTrace == null) { throw new ArgumentNullException(nameof(stackTrace)); } _frames = GetFrames(stackTrace); }
The text was updated successfully, but these errors were encountered:
I also wonder if the same could be done for EnhancedStackFrame: I'm having a lot of performance penalties due to this :(
EnhancedStackFrame
Sorry, something went wrong.
No branches or pull requests
Enhanced classes still do call parent default constructor e.g.:
CaptureStackTrace
call is redundant, it comes fromStackTrace()
constructor.In this case, we could explicitly call
StackTrace(StackFrame frame)
with some dummy value, to avoid an expensive call:The text was updated successfully, but these errors were encountered: