Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article with Featured " No " has active featuring date #90

Open
chmst opened this issue May 7, 2020 · 9 comments
Open

Article with Featured " No " has active featuring date #90

chmst opened this issue May 7, 2020 · 9 comments

Comments

@chmst
Copy link

chmst commented May 7, 2020

Steps to reproduce the issue

If an article is not featured, the input fields for featuring dates are confusing.

featured-article-after-transition

Expected result

Input fields for dates are hidden

Actual result

System information (as much as possible)

Additional comments

@chmst chmst changed the title Article with Featured No has active featuring date Article with Featured " No " has active featuring date May 7, 2020
@HLeithner
Copy link

We should move this to the publishing tab and remove the "on show feature"

@chmst
Copy link
Author

chmst commented May 17, 2020

Not sure about this. It is an attribute of the article not of the transition.

@HLeithner
Copy link

It is a publishing option and should not be at this position at all, in my optionen 'featured' should be at the publishing tab too

@HLeithner
Copy link

And featuring date it self has not much todo if it's on or off

@chmst
Copy link
Author

chmst commented May 17, 2020

you are right, I misunderstood your remark

@chmst
Copy link
Author

chmst commented May 18, 2020

I suggest another solution. You are right, that featured_up /_ down should be on the publishing tab. BUT the the whole thing then is useless because users will not take notice of this new function.

As we must choose between correct and userfriendly
I suggest a javascipt which performs she showon.

@HLeithner
Copy link

onshow is already javascript but there is no reason why featured_up/down is handled differently then publish_up/down. Always showing it is the best option and should belong to the publish tab.

@chmst
Copy link
Author

chmst commented May 18, 2020

There is a reason why the fields are handled differently:

publish_up and publish_down are always valid.
feature_up and feature_down make sense only when featured is "on".

Showing the input fields when the swith is "off" is always wrong, no matter on which tab.
Changing the position of the fields is simple but unfortunately does not resolve the problem

@HLeithner
Copy link

That's not true, publish_up/down required state to be published and feature_up/down required featured to be yes so it's exactly the same.

bembelimen pushed a commit that referenced this issue Dec 7, 2020
Change direction of background gradient for rtl and fix back-to-top button position for rtl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants