Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: this.transports.shift is not a function #17

Open
LordMike opened this issue Mar 26, 2019 · 7 comments · May be fixed by #23
Open

UI: this.transports.shift is not a function #17

LordMike opened this issue Mar 26, 2019 · 7 comments · May be fixed by #23
Assignees
Labels
bug Something isn't working

Comments

@LordMike
Copy link

LordMike commented Mar 26, 2019

This is a UI issue observed with the latest tag, which runs version 0.8.28. 0.8.28 is also a tag which is slightly confusing :|

See jhuckaby/Cronicle#168

Tag 0.8.28 does not exhibit this behaviour.

@belsander
Copy link
Owner

latest uses a different install method. This tag has been created to facilitate auto builds for Docker images in case new releases of Cronicle happen.

For the issue, I can indeed confirm that latest is broken. 0.8.28 does not have this issue. I'll have a look tomorrow what is going wrong in latest

@belsander belsander self-assigned this Mar 27, 2019
@belsander belsander added the bug Something isn't working label Mar 27, 2019
@raymatos
Copy link

was this resovled?

bluet added a commit to bluet/docker-cronicle that referenced this issue Jan 12, 2020
fixed: use node:12-alpine to fix timer issue
fixed: remove problematic ENV (websocket related) to fix dashboard loading issue
fixed: install process for new version of cronicle
fixed: drop privilege too early causes installation failed

fixed jhuckaby/Cronicle#239
fixed belsander#17
@bluet bluet linked a pull request Jan 12, 2020 that will close this issue
@bluet
Copy link

bluet commented Jan 12, 2020

I think I got a fix for the issue in PR #23 .
If anyone's in urgent please check https://github.com/bluet/docker-cronicle and https://hub.docker.com/r/bluet/cronicle

Also I've created another version which supports run each jobs in their own docker container here https://github.com/bluet/docker-cronicle-docker and https://hub.docker.com/r/bluet/cronicle-docker

Hope it helps before @belsander 's review.

@wackazong
Copy link

This is because the JSON property socket_io_transports is set to a string and not to a JSON array. You need a different method to set it, I use jq.

@bluet
Copy link

bluet commented Jul 2, 2020

is this related? #15

@shmakes
Copy link

shmakes commented Nov 3, 2020

Any hope of a fix in this repo?
@wackazong Could you expand a bit on your proposed fix?
Thanks.

@wackazong
Copy link

wackazong commented Nov 4, 2020

The JSON property socket_io_transports ist set to a string in /opt/cronicle/conf/config.json using a special environment variable syntax. This is explicitly disallowed in the Cronicle docs. It simply cannot be done using the method that is used in the Docker file. So there is no easy fix. The Cronicle docs state:

Almost every configuration property can be overridden using this environment variable syntax. The only exceptions are things like arrays, e.g. log_columns and socket_io_transports.

Therefore the config parameter socket_io_transports cannot be set to an array using the environment variable syntax. Either remove it to leave it at the default or set it using another way, e.g. jq.

Normally it should be fine to just remove it. I will submit a pull request to this repo to remove it as it will not work setting it this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants