Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Crypto API #141

Closed
7heMech opened this issue May 2, 2024 · 5 comments
Closed

Web Crypto API #141

7heMech opened this issue May 2, 2024 · 5 comments

Comments

@7heMech
Copy link
Contributor

7heMech commented May 2, 2024

Maybe you could replace jssha package with the Web Crypto API which is pretty much supported everywhere, and would be way faster since it's natively implemented by the runtimes.

@bellstrand
Copy link
Owner

@7heMech This is an issue tracker.
Feel free to open a PR if you'd like to contribute additional or improved functionality to this repository.

@7heMech
Copy link
Contributor Author

7heMech commented May 4, 2024

@bellstrand I'd be happy to contribute, also what do you think about switching to bun (will make tests way faster) would it be fine if I created a PR for that as well?

@7heMech
Copy link
Contributor Author

7heMech commented May 4, 2024

Also webcrypto api supports only "SHA-1" | "SHA-256" | "SHA-384" | "SHA-512" maybe that's a deal-breaker?

@bellstrand
Copy link
Owner

@7heMech Good question, It's not a deal-breaker for me personally. But let me check around some of the open-source repos using this to see which are heavily in use first!

I'm not against switching to bun per-se, but it would require replacing Dependabot as well.
So i'd rather wait for dependabot/dependabot-core#6528 before making that switch :)

@bellstrand
Copy link
Owner

I looks like SHA-1 AND SHA-512 covers almost all cases I can find, so I'm all for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants