Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing for retriever is too strict: implement abstract retriever base class #152

Open
jon-chuang opened this issue Jul 10, 2023 · 0 comments
Open

Typing for retriever is too strict: implement abstract retriever base class #152

jon-chuang opened this issue Jul 10, 2023 · 0 comments

Comments

@jon-chuang
Copy link

jon-chuang commented Jul 10, 2023 •
edited
Loading

One should be able to evaluate BEIR on other retrievers other than Union[Type[DRES], Type[DRFS], Type[BM25], Type[SS]

The work around is the use the static method evaluate. It's slightly awkward. See SPLADE's eval
https://github.com/naver/splade/blob/06947de1da83e5443809f1b7e78937416d53c14b/splade/beir_eval.py#L85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jon-chuang