-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scenario_autoretry does not reset runner.hook_failures #1128
Comments
Mmh, you seem to have flaky tests. The SOLUTION SKETCH: SEE ALSO: |
@jenisys Yes obviously we'd prefer the tests not to be flaky. But reality ensues. I don't know what you mean by the "test-runner state". |
|
The scenario_autoretry monkey patch does not intervene with or reset the increment of
self.hook_failures
in the runner. Consequently, if before_scenario/after_scenario fails the first time, and then passes on the retry, behave still exits with failure at the end becausehook_failures
is non-zero.behave/behave/runner.py
Line 649 in 1c6197b
behave/behave/runner.py
Lines 751 to 755 in 1c6197b
The text was updated successfully, but these errors were encountered: