Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voiceover hint for macOS DetailedList items isn't helpful #2506

Open
freakboy3742 opened this issue Apr 15, 2024 · 0 comments
Open

Voiceover hint for macOS DetailedList items isn't helpful #2506

freakboy3742 opened this issue Apr 15, 2024 · 0 comments
Labels
bug A crash or error in behavior. macOS The issue relates to Apple macOS support.

Comments

@freakboy3742
Copy link
Member

Describe the bug

On macOS, the Voiceover assistant describes the content of DetailedList items as "<TogaData: 0xdeadbeef>", or similar. This isn't very helpful for navigation purposes.

Steps to reproduce

  1. Run the DetailedList example
  2. Turn on VoiceOver (Command-F5)
  3. Select an item

The text that is read won't be the title and subtitle, but "<Togadata...>"

Expected behavior

The VoiceOver description should accurately describe the content of the list item

Screenshots

Environment

  • Operating System: macOS
  • Python version: All
  • Software versions:
    • Toga: 0.4.2+

Logs


Additional context

The fix for this is to add an accessibilityValue() objc_method to the implementation of TogaDetailedCell. This is the macOS native implementation of an item in a detailedList; the default implementation is to read the description of the objectValue instance associated with the cell, which is a TogaData object.

We can reliably know that the objectValue will be a TogaData object with title and subtitle keys; these can be used to construct a description that can be read.

See #2233 for a related accessibility feature.

@freakboy3742 freakboy3742 added bug A crash or error in behavior. macOS The issue relates to Apple macOS support. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior. macOS The issue relates to Apple macOS support.
Projects
None yet
Development

No branches or pull requests

1 participant