Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should drop Python 3.7 #5222

Open
wisp3rwind opened this issue May 4, 2024 · 6 comments
Open

We should drop Python 3.7 #5222

wisp3rwind opened this issue May 4, 2024 · 6 comments
Labels

Comments

@wisp3rwind
Copy link
Member

In #5215, our minimum supported Python version came up: We currently state 3.7, but that's been EOL since June 2023. I think we should drop that and allow 3.8+ features. Any objections?

@wisp3rwind
Copy link
Member Author

@sampsyo @Serene-Arc @snejus @arsaboo @JOJ0 just pinging a bunch of recently active people here.

@Serene-Arc
Copy link
Contributor

I have no objections, seems like a good idea to me

@arsaboo
Copy link
Contributor

arsaboo commented May 4, 2024

Agreed... no objections.

@Serene-Arc
Copy link
Contributor

Because I was looking at the corresponding issue, I think we should hold off on this change until October, because Python 3.8 reaches EOL then. If we change it now, we'll have to raise it again a month or two later anyway. Might be easier on everyone if we just upgrade to 3.9 all at once.

@snejus
Copy link
Member

snejus commented Jun 3, 2024

@Serene-Arc #5266 requires 3.8 as a minimum, since we are using tox version 4 which requires 3.8 as a minimum, and without it dependency resolution fails.

Dropping 3.7 and then 3.8 later as separate steps may be a less risky option. If I imagine myself as a Python 3.7 user, I'd prefer upgrading step by step rather than having to jump two Python versions. It's also slightly easier for us developers: for example, 3.7 -> 3.8 and 3.8 -> 3.9 upgrades in separate PRs require less mental effort and can be reviewed by multiple people in parallel, in comparison to a single PR which upgrades 3.7 -> 3.9. This would be more complicated to deal with and we are more likely to miss out on issues.

@Serene-Arc
Copy link
Contributor

Good points, let's do that then. We should start planning for 3.9 pretty soon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants