-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support slice type values #66
Comments
@YafimK keep in mind that you have to support also all the other ways of setting it up like env vars, flags etc... |
@YafimK This can also be achieved using a custom type, instead of list specific one. I think we should stick to the bare minimum ( |
hmm I understand there is some complexity to it, but I do think that slice are really bare minimal support type.. as they are widely used, for example, passing list of addresses and etc. Making customization for basic golang supported type feels a bit strange. I'd be happy to any help of course. |
Since we have to support also other sources like env vars which are only strings we have to find a unique delimiter for each value, split the string based on that and parse based on the underlying slice type (int, float,etc.). Correct? |
@YafimK, we won't move on with this issue as we don't think at the moment that this can be part of the library. We have created custom types support for these cases. |
|
I think it's useful to add slice types, the delimiter(s) can be defined also as a tag |
Is this a bug? Please provide steps to reproduce, a failing test etc.
Add support to load slice field types - allowing to put slice type values in consul as lists.
Describe the solution
load the slice by the slice type (which must be one of the supported types implementing cfg type).
The text was updated successfully, but these errors were encountered: