-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--all will create duplicate report entries on win32 #191
Comments
That seems to work but I'm having a hard time figuring out how to flex it in a test :/ |
@j03m I'd be fine with detecting the environment, and having a test case that only runs in Windows. |
@bcoe cool. I'm sort of working on that. Testing it seems to involve changing more code to mock and inject dependencies then I would like. Super messy :/. Trying to figure out a better way. |
#192 will fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a bit of a "canned" issue because it assumes that #183 is fixed upstream. But when testing out my fix istanbuljs/test-exclude#44 I noticed there is an additional path casing issue in
c8
related to the implementation of--all
.On windows, using local files it is possible for v8 to generate file names like:
d:\path\to\my\file.js
note the lower case drive letter.
But later when find
--all
files the node api post call toresolve
will return the same string paths with a upper case drive letter. This is what originally caused #183.However, once #183 is fixed and
test-exclude
'sshouldInstrument
returns true for case mismatches, this additional mismatch inc8
'sfileIndex
Set which we use to track if a file has been seen causes duplicates in the final report:For example the output might be as follows:
My current thoughts were to replace
fileIndex
theSet
with an overridden Set that wouldtoLowerCase
keys whenwin32
is detected.The text was updated successfully, but these errors were encountered: