Fix tests with phpunit10 #6220
Open
Fix tests with phpunit10 #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzap
force-pushed
the
phpunit10
branch
2 times, most recently
from
d00f88f
to
055438a
Compare
|
All commits except one work also when run on phpunit9. |
Commit updated, it should now run on older phpunit versions too. |
Output was produced with: . phpunit --migrate-configuration . Error was: . Warning: Your XML configuration validates against a deprecated schema. Suggestion: Migrate your XML configuration using "--migrate-configuration"!
Produced by: phpunit --migrate-configuration
Fatal error: Cannot override final method PHPUnit\Framework\TestCase::runBare() in tests/mocks/ci_testcase.php on line 351
Was removed in phpunit10 Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
1) Class security_helper_test cannot be found in tests/codeigniter/helpers/security_helper_test.php
This reverts commit 8f12bc3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the errors, warning & deprecations when testing with phpunit10
Pick whatever you may find relevant and a correct fix.
It is assumed this is run with phpunit 10.2 & php 8.2 (and that the php8.2 fixes of #6173 are already applied.
Might close #6219