Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRO Decommission - Consumed By Field in NAMEX not Populated once NR is Consumed #24932

Open
ozamani9gh opened this issue Dec 13, 2024 · 4 comments
Assignees
Labels
High Priority Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex

Comments

@ozamani9gh
Copy link
Collaborator

Consumed By Field in NAMEX not Populated once NR is Consumed: https://sbc-registries.atlassian.net/browse/ITOPS-154697

I believe this is a defect in NRO Decommissioning code for the modern NAMES team.

I have found that, for Change of Name NRs, the Consumed By field is not populated with the registration number of the business entity that has consumed the NR. So far, we have found that this defect impacts NRs for LPs and LLPs.

Here is a screenshot from PROD, which identifies the correct behaviour (Note: Consumed By field is populated):

image.png

Here is a screenshot from TEST, which shows that the Consumed By field is no longer populated:

image.png

I have confirmed with the business that PROD is correct; TEST is not. As above, I believe this defect is for the modern NAMES team because we are not supposed to be syncing data anymore. If I am incorrect, though, please pass this defect back to David Li.,

@ozamani9gh ozamani9gh added High Priority Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex labels Dec 13, 2024
@eve-git
Copy link
Collaborator

eve-git commented Dec 13, 2024

when changing state to 'CONSUMED', corpNum is required. NR 9161963 in TEST didn't update the names.corp_num. image.png
We may need to and condition when corp_num is empty in the input.

@eve-git
Copy link
Collaborator

eve-git commented Dec 13, 2024

In TEST:

select nr_id, name, state, consumption_date, corp_num from names where nr_id = (select id from requests where nr_num='NR 8161963')
--"nr_id"	"name"	"state"	"consumption_date"	"corp_num"
--202072	"NRO DECOMMISSIONING 3 XPRO LLP"	"APPROVED"	"2024-12-12 23:17:11.996314+00"	" "
select * from events 
where  nr_id = (select id from requests where nr_num='NR 8161963')
order by event_dt desc
--"id"	"event_dt"	"action"	"json_zip"	"nr_id"	"user_id"	"state_cd"	"event_json"
--84046	"2024-12-12 23:17:12.000867+00"	"patch"		202072	223	"CONSUMED"	"""{\""state\"": \""CONSUMED\"", \""corpNum\"": \"" \""}"""

@eve-git
Copy link
Collaborator

eve-git commented Dec 13, 2024

Here is a sample consumption event from Entities in the PRODUCTION environment. It seems our current coding logic will also work for Entities without requiring any changes.

10619962	"2024-07-05 17:25:29.835583"	"patch"		2531539	76	"CONSUMED"	"""{\""consume\"": {\""corpNum\"": \""FM1050474\""}}"""

@ozamani9gh
Copy link
Collaborator Author

Ticket is assigned to David Li of Home Team. We will wait till changes are in dev/test and then we can confirm the event_json has the corpnum in it, and the UI displays it. At this point i dont think any coding is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex
Projects
None yet
Development

No branches or pull requests

3 participants