Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circuit breaker to while loop in getMatomoInfo() in newslabs header #8

Open
dannymeloy opened this issue Apr 26, 2024 · 0 comments

Comments

@dannymeloy
Copy link

dannymeloy commented Apr 26, 2024

If the backend (/whois or /whoami endpoints) is unreachable, this results in the getMatomoInfo() function not returning / erroring, which in turn stops downstream services (ie. C&M) from being able to boot.

This appears to have occurred during testing.

A early return statement could be added or an error could be thrown if this request is unsuccessful after a number of attempts.

Note: If the request times out, whilst it shows in the network tab, the error is not thrown inside the getMatomoInfo function, so does not cause downstream services to exit.

@bennuttall bennuttall changed the title Add circuit breaker to while loop in getMatomoInfo() in newslab header Add circuit breaker to while loop in getMatomoInfo() in newslabs header Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant